Skip to content

fix(chi): emit event for reconcile error - #2165

Open
devmalcevv wants to merge 1 commit into
Altinity:0.28.0from
devmalcevv:chi-reconcilation
Open

devmalcevv wants to merge 1 commit into
Altinity:0.28.0from
devmalcevv:chi-reconcilation

Conversation

@devmalcevv

@devmalcevv devmalcevv commented Nov 18, 2026 •

Copy link
Copy Markdown

Summary

Fixes #1650

Basically, same as b92d58e44. The identical code for Keeper in pkg/controller/chk/worker-service.go, but the CHI copy wasn't changed.

Unlike the keeper version I've added apiErrors.IsInvalid(err) check because test_010012 would fail (see logs below)

tests pass with `IsInvalid`
Passing

✔ [ OK ] /regression/e2e.test_operator/test_010012. Test service templates (4m 21s)
✔ [ OK ] /regression/e2e.test_operator (4m 21s)
✔ [ OK ] /regression (4m 21s)

Coverage

QA-SRS026 ClickHouse Operator
  262 requirements (6 satisfied 2.3%, 256 untested 97.7%)

1 suite (1 ok)
1 feature (1 ok)
1 scenario (1 ok)
85 steps (85 ok)

Total time 4m 21s
tests failing without `IsInvalid`
      kubectl.check_service("service-test-012-0-0", "ClusterIP", headless = True)
    File "/.../clickhouse-operator/tests/e2e/kubectl.py", line 1154, in check_service
      assert clusterIP == "None"
             ^^^^^^^^^^^^^^^^^^^
  AssertionError

Failing

✘ [ Fail ] /regression/e2e.test_operator/test_010012. Test service templates (2m 53s)
✘ [ Fail ] /regression/e2e.test_operator (2m 53s)
✘ [ Fail ] /regression (2m 53s)

Coverage

QA-SRS026 ClickHouse Operator
  262 requirements (6 unsatisfied 2.3%, 256 untested 97.7%)

1 suite (1 failed)
1 feature (1 failed)
1 scenario (1 failed)
75 steps (71 ok, 4 failed)

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

Signed-off-by: Viacheslav Maltsev <devmalcevv@gmail.com>
@devmalcevv
devmalcevv marked this pull request as ready for review November 18, 2026 17:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant