Repository navigation
fix(chi): emit event for reconcile error - #2165
Open
devmalcevv wants to merge 1 commit into
Open
devmalcevv wants to merge 1 commit into
devmalcevv wants to merge 1 commit into
Conversation
Signed-off-by: Viacheslav Maltsev <devmalcevv@gmail.com>
devmalcevv
marked this pull request as ready for review
November 18, 2026 17:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1650
Basically, same as b92d58e44. The identical code for Keeper in pkg/controller/chk/worker-service.go, but the CHI copy wasn't changed.
Unlike the keeper version I've added
apiErrors.IsInvalid(err)check because test_010012 would fail (see logs below)tests pass with `IsInvalid`
tests failing without `IsInvalid`
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.