Repository navigation
Conversation
jsc0218
marked this pull request as draft
November 19, 2026 21:49
Signed-off-by: Shichao <shichao.jin@enterprisedb.com>
jsc0218
force-pushed
the
test-010016-wait-config-reload
branch
from
November 19, 2026 22:08
be88738 to
48b212d
Compare
jsc0218
marked this pull request as ready for review
November 19, 2026 22:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2168
test_010016waits for the new value in the pod's settings file and then queriessystem.macrosanddictGetimmediately. ClickHouse reloads its config on its own timer, so the query can return the old value.Add
clickhouse.wait_query_resultand use it for both checks, so they retry until the expected value shows up.