Skip to content

Source code (Fortran 90 format) for Appendix B. - #64

Merged
jeanwsr merged 7 commits into
nominhanggai:masterfrom
zhaixiaoyi001:add-src
Feb 5, 2026
Merged

jeanwsr merged 7 commits into
nominhanggai:masterfrom
zhaixiaoyi001:add-src

Conversation

@zhaixiaoyi001

Copy link
Copy Markdown
Contributor
  1. Removed the jump and rewrote the DO and IF.
  2. Retained the variables and the electronic integral calculation from the original code.
  3. Diagonalization is performed using LAPACK; some variables are redundant and have not been removed.

1. Removed the jump and rewrote the DO and IF.
2. Retained the variables and the electronic integral calculation from the original code.
3. Diagonalization is performed using LAPACK; some variables are redundant and have not been removed.
@jeanwsr

jeanwsr commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

I think it's a little off-topic to add such revised codes in a "book translation" repo, since the code revision has nothing to do with book translation. But still I'm open to merge this if it's beneficial for readers. For better understanding the code status, Could you rename your code file to AppendixBcode_revised.f90 and add a README.md under that folder which documents your revision.

@SeptemberMy

Copy link
Copy Markdown
Contributor

I think it's a little off-topic to add such revised codes in a "book translation" repo, since the code revision has nothing to do with book translation. But still I'm open to merge this if it's beneficial for readers. For better understanding the code status, Could you rename your code file to AppendixBcode_revised.f90 and add a README.md under that folder which documents your revision.

From a translation perspective, you are right, but this project is not a complete replication of the original book. Many of the figures have been redrawn. When I translated the appendix, I found that the code provided in the original book was difficult to compile and run. So after discovering his updated code, I felt it would be helpful to readers and recommended him to submit a pull request.

@jeanwsr

jeanwsr commented Jan 31, 2026

Copy link
Copy Markdown
Collaborator

From a translation perspective, you are right, but this project is not a complete replication of the original book. Many of the figures have been redrawn. When I translated the appendix, I found that the code provided in the original book was difficult to compile and run. So after discovering his updated code, I felt it would be helpful to readers and recommended him to submit a pull request.

ok that makes sense.

@zhaixiaoyi001

Copy link
Copy Markdown
Contributor Author

I have rename the code file to AppendixBcode_revised.f90 and add a README.md under the folder.

@SeptemberMy

Copy link
Copy Markdown
Contributor

I have rename the code file to AppendixBcode_revised.f90 and add a README.md under the folder.

I suggest attaching the output file of you code for reference.

@zhaixiaoyi001

Copy link
Copy Markdown
Contributor Author

The output file of the code has been added.

@jeanwsr
jeanwsr merged commit 15f4110 into nominhanggai:master Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants