Repository navigation
Conversation
A slice field tagged ini:",autoincrement" gets the values of its section's "- = value" lines from MapTo, and ReflectFrom replaces those lines with one per element (#240).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
- = valuelines are read as auto-increment keys named#1,#2…, but struct mapping had no way to reach them. The issue'sini:"-"already means "skip this field", so this adds a tag option instead:[Agents] - = installRoot/agent_1.0.0 - = installRoot/agent_1.0.1MapTo: the slice gets the values of the section's auto-increment keys, in order, expanded like any value (%(name)sworks). Elements parse as in other slice fields: an invalid one is the zero value inMapToand an error inStrictMapTo. A section without such keys leaves the field unchanged.ReflectFrom: the section's auto-increment keys are replaced by one- = elementline per element, after its other keys. Since each element is its own line, elements may contain the delimiter.parseTagOptionsnow splits on every comma, since a sixth option no longer fit inSplitN(tag, ",", 5).Link to the issue: closes #240
Checklist
AI usage
Written by Amp (an AI coding agent) at the maintainer's request. Validation:
go test ./...,go vet, and 30 s ofFuzzStructMapping.TestAutoIncrementuses the issue's file with a regular key between the-lines, typed elements in strict and lenient mode, aReflectFromthat replaces existing lines and round-trips, and a non-slice field. Every case fails when the option is ignored.