Skip to content

feat(ci): move reviewer absence list to ABSENCE_LIST repository variable - #1703

Open
VLukiantsev wants to merge 1 commit into
mainfrom
grain/65c50381/task-77-move-absence-content-to-the
Open

VLukiantsev wants to merge 1 commit into
mainfrom
grain/65c50381/task-77-move-absence-content-to-the

Conversation

@VLukiantsev

@VLukiantsev VLukiantsev commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

feat(ci): move reviewer absence list to ABSENCE_LIST repository variable

Summary

Moves the PR reviewer and nightly failure alert absence configuration from ABSENCE.md in the repository root to the ABSENCE_LIST GitHub Actions repository variable (vars.ABSENCE_LIST), eliminating the need to open and merge pull requests when updating reviewer out-of-office schedules.

Key Changes

  • GitHub Actions Workflows: Inject ABSENCE_LIST: ${{ vars.ABSENCE_LIST }} into the Select and Assign Reviewers step in .github/workflows/auto-assign-reviewers.yml and the Alert Repository OWNERS on GitHub Issue step in .github/workflows/nightly-examples-e2e.yml.
  • Absence Schedule & Reviewer Assignment: Update .github/scripts/absence-schedule.js, .github/scripts/assign-reviewers.js, and .github/scripts/nightly-failure-alert.js to read and parse process.env.ABSENCE_LIST (supporting multiline and comma/semicolon-separated entries while stripping # comments first).
  • Retire ABSENCE.md & Auto-Approve Workflow: Remove ABSENCE.md, .github/workflows/auto-approve-absence.yml, .github/scripts/auto-approve-absence.js, and .github/scripts/auto-approve-absence.test.js, relocating isAuthorCodeOwner into .github/scripts/assign-reviewers.js.
  • Documentation & Tests: Update .github/scripts/README.md, docs/ci_runner_infrastructure.md, .agents/rules/github_authoring_and_prs.md, and unit tests across .github/scripts/*.test.js.

Testing

  • Verified all 222 unit tests across 11 test suites pass via node --test .github/scripts/*.test.js.
  • Verified repository pre-commit checks pass via ./.githooks/pre-commit.

Assumptions

None — requirements were fully specified.

TAG=agy
CONV=6db67ffc-2440-47c4-95c3-b83105afe003

Requested-by: vluk@google.com
Approved-by: vluk@google.com


Automated change for grain task 77.

@github-actions
github-actions Bot requested a review from janzak-dev November 16, 2026 15:32

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the reviewer absence tracking from a local ABSENCE.md file to a dynamically resolved ABSENCE_LIST environment variable or GitHub repository variable. It updates the parsing logic to support comma and semicolon delimiters, adapts the reviewer assignment and nightly failure alert scripts to use this new resolution helper, and updates the corresponding test suites. Feedback suggests expanding the test coverage for resolveAbsenceContent to explicitly verify the github.request fallback path.

VLukiantsev added a commit that referenced this pull request Nov 16, 2026
Adds unit test coverage in `.github/scripts/absence-schedule.test.js` for the `github.request('GET /repos/{owner}/{repo}/actions/variables/{name}')` fallback path in `resolveAbsenceContent`.

Comment link: #1703 (comment)

TAG=agy
CONV=6db67ffc-2440-47c4-95c3-b83105afe003

Requested-by: vluk@google.com
Approved-by: vluk@google.com
@VLukiantsev
VLukiantsev removed the request for review from janzak-dev November 16, 2026 18:56
## Summary
Moves the PR reviewer and nightly failure alert absence configuration from `ABSENCE.md` in the repository root to the `ABSENCE_LIST` GitHub Actions repository variable (`vars.ABSENCE_LIST`), eliminating the need to open and merge pull requests when updating reviewer out-of-office schedules.

## Key Changes
- **GitHub Actions Workflows**: Inject `ABSENCE_LIST: ${{ vars.ABSENCE_LIST }}` into the `Select and Assign Reviewers` step in `.github/workflows/auto-assign-reviewers.yml` and the `Alert Repository OWNERS on GitHub Issue` step in `.github/workflows/nightly-examples-e2e.yml`.
- **Absence Schedule & Reviewer Assignment**: Update `.github/scripts/absence-schedule.js`, `.github/scripts/assign-reviewers.js`, and `.github/scripts/nightly-failure-alert.js` to read and parse `process.env.ABSENCE_LIST` (supporting multiline and comma/semicolon-separated entries while stripping `#` comments first).
- **Retire `ABSENCE.md` & Auto-Approve Workflow**: Remove `ABSENCE.md`, `.github/workflows/auto-approve-absence.yml`, `.github/scripts/auto-approve-absence.js`, and `.github/scripts/auto-approve-absence.test.js`, relocating `isAuthorCodeOwner` into `.github/scripts/assign-reviewers.js`.
- **Documentation & Tests**: Update `.github/scripts/README.md`, `docs/ci_runner_infrastructure.md`, `.agents/rules/github_authoring_and_prs.md`, and unit tests across `.github/scripts/*.test.js`.

## Testing
- Verified all 222 unit tests across 11 test suites pass via `node --test .github/scripts/*.test.js`.
- Verified repository pre-commit checks pass via `./.githooks/pre-commit`.

## Assumptions
None — requirements were fully specified.

TAG=agy
CONV=6db67ffc-2440-47c4-95c3-b83105afe003

Requested-by: vluk@google.com
Approved-by: vluk@google.com
@VLukiantsev
VLukiantsev force-pushed the grain/65c50381/task-77-move-absence-content-to-the branch from a5d7d61 to c93b014 Compare November 16, 2026 19:20
@VLukiantsev

Copy link
Copy Markdown
Collaborator Author

grain security hold (task 77)

#1703 touches grain's trust boundary, so it is no longer merging automatically and requires a passing security review.

Trust-boundary paths (trust-boundary/v28):

  • github-workflows (built in) -- GitHub Actions workflows:
    • .github/workflows/auto-approve-absence.yml
    • .github/workflows/auto-assign-reviewers.yml
    • .github/workflows/nightly-examples-e2e.yml

Filed task 85 to review it. If that review finishes without findings, this change merges automatically once CI passes; if it leaves findings, it waits for fixes and a clean re-review. Pressing Submit records your approval only and never skips the review.

@github-actions
github-actions Bot requested a review from AntonTyb November 16, 2026 20:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant