Repository navigation
feat(ci): move reviewer absence list to ABSENCE_LIST repository variable - #1703
VLukiantsev wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the reviewer absence tracking from a local ABSENCE.md file to a dynamically resolved ABSENCE_LIST environment variable or GitHub repository variable. It updates the parsing logic to support comma and semicolon delimiters, adapts the reviewer assignment and nightly failure alert scripts to use this new resolution helper, and updates the corresponding test suites. Feedback suggests expanding the test coverage for resolveAbsenceContent to explicitly verify the github.request fallback path.
Adds unit test coverage in `.github/scripts/absence-schedule.test.js` for the `github.request('GET /repos/{owner}/{repo}/actions/variables/{name}')` fallback path in `resolveAbsenceContent`.
Comment link: #1703 (comment)
TAG=agy
CONV=6db67ffc-2440-47c4-95c3-b83105afe003
Requested-by: vluk@google.com
Approved-by: vluk@google.com
## Summary
Moves the PR reviewer and nightly failure alert absence configuration from `ABSENCE.md` in the repository root to the `ABSENCE_LIST` GitHub Actions repository variable (`vars.ABSENCE_LIST`), eliminating the need to open and merge pull requests when updating reviewer out-of-office schedules.
## Key Changes
- **GitHub Actions Workflows**: Inject `ABSENCE_LIST: ${{ vars.ABSENCE_LIST }}` into the `Select and Assign Reviewers` step in `.github/workflows/auto-assign-reviewers.yml` and the `Alert Repository OWNERS on GitHub Issue` step in `.github/workflows/nightly-examples-e2e.yml`.
- **Absence Schedule & Reviewer Assignment**: Update `.github/scripts/absence-schedule.js`, `.github/scripts/assign-reviewers.js`, and `.github/scripts/nightly-failure-alert.js` to read and parse `process.env.ABSENCE_LIST` (supporting multiline and comma/semicolon-separated entries while stripping `#` comments first).
- **Retire `ABSENCE.md` & Auto-Approve Workflow**: Remove `ABSENCE.md`, `.github/workflows/auto-approve-absence.yml`, `.github/scripts/auto-approve-absence.js`, and `.github/scripts/auto-approve-absence.test.js`, relocating `isAuthorCodeOwner` into `.github/scripts/assign-reviewers.js`.
- **Documentation & Tests**: Update `.github/scripts/README.md`, `docs/ci_runner_infrastructure.md`, `.agents/rules/github_authoring_and_prs.md`, and unit tests across `.github/scripts/*.test.js`.
## Testing
- Verified all 222 unit tests across 11 test suites pass via `node --test .github/scripts/*.test.js`.
- Verified repository pre-commit checks pass via `./.githooks/pre-commit`.
## Assumptions
None — requirements were fully specified.
TAG=agy
CONV=6db67ffc-2440-47c4-95c3-b83105afe003
Requested-by: vluk@google.com
Approved-by: vluk@google.com
a5d7d61 to
c93b014
Compare
|
grain security hold (task 77) #1703 touches grain's trust boundary, so it is no longer merging automatically and requires a passing security review. Trust-boundary paths (trust-boundary/v28):
Filed task 85 to review it. If that review finishes without findings, this change merges automatically once CI passes; if it leaves findings, it waits for fixes and a clean re-review. Pressing Submit records your approval only and never skips the review. |
feat(ci): move reviewer absence list to ABSENCE_LIST repository variable
Summary
Moves the PR reviewer and nightly failure alert absence configuration from
ABSENCE.mdin the repository root to theABSENCE_LISTGitHub Actions repository variable (vars.ABSENCE_LIST), eliminating the need to open and merge pull requests when updating reviewer out-of-office schedules.Key Changes
ABSENCE_LIST: ${{ vars.ABSENCE_LIST }}into theSelect and Assign Reviewersstep in.github/workflows/auto-assign-reviewers.ymland theAlert Repository OWNERS on GitHub Issuestep in.github/workflows/nightly-examples-e2e.yml..github/scripts/absence-schedule.js,.github/scripts/assign-reviewers.js, and.github/scripts/nightly-failure-alert.jsto read and parseprocess.env.ABSENCE_LIST(supporting multiline and comma/semicolon-separated entries while stripping#comments first).ABSENCE.md& Auto-Approve Workflow: RemoveABSENCE.md,.github/workflows/auto-approve-absence.yml,.github/scripts/auto-approve-absence.js, and.github/scripts/auto-approve-absence.test.js, relocatingisAuthorCodeOwnerinto.github/scripts/assign-reviewers.js..github/scripts/README.md,docs/ci_runner_infrastructure.md,.agents/rules/github_authoring_and_prs.md, and unit tests across.github/scripts/*.test.js.Testing
node --test .github/scripts/*.test.js../.githooks/pre-commit.Assumptions
None — requirements were fully specified.
TAG=agy
CONV=6db67ffc-2440-47c4-95c3-b83105afe003
Requested-by: vluk@google.com
Approved-by: vluk@google.com
Automated change for grain task 77.